On 07/04/2016 06:42 PM, Arnd Bergmann wrote: > The newly added tsens-8916 driver produces warnings when CONFIG_PM > is disabled: > > drivers/thermal/qcom/tsens.c:53:12: error: 'tsens_resume' defined but not > used [-Werror=unused-function] > static int tsens_resume(struct device *dev) > ^~~~~~~~~~~~ > drivers/thermal/qcom/tsens.c:43:12: error: 'tsens_suspend' defined but not > used [-Werror=unused-function] > static int tsens_suspend(struct device *dev) > ^~~~~~~~~~~~~ > > This marks both functions __maybe_unused to let the compiler > know that they might be used in other configurations, without > adding ugly #ifdef logic.
Thanks Arnd, Reviewed-by: Rajendra Nayak <[email protected]> > > Signed-off-by: Arnd Bergmann <[email protected]> > --- > drivers/thermal/qcom/tsens.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index 446f70b5dbb2..e4fca3350d26 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -40,7 +40,7 @@ static int tsens_get_trend(void *p, int trip, enum > thermal_trend *trend) > return -ENOTSUPP; > } > > -static int tsens_suspend(struct device *dev) > +static int __maybe_unused tsens_suspend(struct device *dev) > { > struct tsens_device *tmdev = dev_get_drvdata(dev); > > @@ -50,7 +50,7 @@ static int tsens_suspend(struct device *dev) > return 0; > } > > -static int tsens_resume(struct device *dev) > +static int __maybe_unused tsens_resume(struct device *dev) > { > struct tsens_device *tmdev = dev_get_drvdata(dev); > > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
