On Fri, Jul 08, 2016 at 03:38:51PM +0200, Ingo Molnar wrote:
> Btw., could we make it .L_restore to make it more readable - or does the 
> underscore confuse tooling?

Nah, builds fine too.

---
From: Borislav Petkov <[email protected]>
Date: Fri, 8 Jul 2016 16:01:48 +0200
Subject: [PATCH v1.1] x86/asm/entry: Make thunk's restore a local label

No need to have it appear in objdump output.

No functionality change.

Signed-off-by: Borislav Petkov <[email protected]>
---
 arch/x86/entry/thunk_64.S | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/entry/thunk_64.S b/arch/x86/entry/thunk_64.S
index 027aec4a74df..627ecbcb2e62 100644
--- a/arch/x86/entry/thunk_64.S
+++ b/arch/x86/entry/thunk_64.S
@@ -33,7 +33,7 @@
        .endif
 
        call \func
-       jmp  restore
+       jmp  .L_restore
        _ASM_NOKPROBE(\name)
        .endm
 
@@ -54,7 +54,7 @@
 #if defined(CONFIG_TRACE_IRQFLAGS) \
  || defined(CONFIG_DEBUG_LOCK_ALLOC) \
  || defined(CONFIG_PREEMPT)
-restore:
+.L_restore:
        popq %r11
        popq %r10
        popq %r9
@@ -66,5 +66,5 @@ restore:
        popq %rdi
        popq %rbp
        ret
-       _ASM_NOKPROBE(restore)
+       _ASM_NOKPROBE(.L_restore)
 #endif
-- 
2.7.3

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Reply via email to