From: Anna-Maria Gleixner <[email protected]>

Install the callbacks via the state machine.

Signed-off-by: Anna-Maria Gleixner <[email protected]>
---
 arch/arc/kernel/time.c     |   32 ++++++++++++++------------------
 include/linux/cpuhotplug.h |    1 +
 2 files changed, 15 insertions(+), 18 deletions(-)

--- a/arch/arc/kernel/time.c
+++ b/arch/arc/kernel/time.c
@@ -296,30 +296,23 @@ static irqreturn_t timer_irq_handler(int
        return IRQ_HANDLED;
 }
 
-static int arc_timer_cpu_notify(struct notifier_block *self,
-                               unsigned long action, void *hcpu)
+
+static int arc_timer_starting_cpu(unsigned int cpu)
 {
        struct clock_event_device *evt = this_cpu_ptr(&arc_clockevent_device);
 
        evt->cpumask = cpumask_of(smp_processor_id());
 
-       switch (action & ~CPU_TASKS_FROZEN) {
-       case CPU_STARTING:
-               clockevents_config_and_register(evt, arc_timer_freq,
-                                               0, ULONG_MAX);
-               enable_percpu_irq(arc_timer_irq, 0);
-               break;
-       case CPU_DYING:
-               disable_percpu_irq(arc_timer_irq);
-               break;
-       }
-
-       return NOTIFY_OK;
+       clockevents_config_and_register(evt, arc_timer_freq, 0, ULONG_MAX);
+       enable_percpu_irq(arc_timer_irq, 0);
+       return 0;
 }
 
-static struct notifier_block arc_timer_cpu_nb = {
-       .notifier_call = arc_timer_cpu_notify,
-};
+static int arc_timer_dying_cpu(unsigned int cpu)
+{
+       disable_percpu_irq(arc_timer_irq);
+       return 0;
+}
 
 /*
  * clockevent setup for boot CPU
@@ -329,7 +322,10 @@ static void __init arc_clockevent_setup(
        struct clock_event_device *evt = this_cpu_ptr(&arc_clockevent_device);
        int ret;
 
-       register_cpu_notifier(&arc_timer_cpu_nb);
+       cpuhp_setup_state_nocalls(CPUHP_AP_ARC_TIMER_STARTING,
+                                 "AP_ARC_TIMER_STARTING",
+                                 arc_timer_starting_cpu,
+                                 arc_timer_dying_cpu);
 
        arc_timer_irq = irq_of_parse_and_map(node, 0);
        if (arc_timer_irq <= 0)
--- a/include/linux/cpuhotplug.h
+++ b/include/linux/cpuhotplug.h
@@ -50,6 +50,7 @@ enum cpuhp_state {
        CPUHP_AP_ARMADA_TIMER_STARTING,
        CPUHP_AP_MARCO_TIMER_STARTING,
        CPUHP_AP_MIPS_GIC_TIMER_STARTING,
+       CPUHP_AP_ARC_TIMER_STARTING,
        CPUHP_AP_KVM_STARTING,
        CPUHP_AP_KVM_ARM_VGIC_STARTING,
        CPUHP_AP_KVM_ARM_TIMER_STARTING,


Reply via email to