* Anna-Maria Gleixner <[email protected]> wrote:

> More or less straightforward, although this driver sports some very
> interesting SMP setup code. Regarding the callback ordering, this
> deleted comment is interesting:
> 
>    ... the GIC needs to be up before the ARM generic timers.
> 
> That comment is half baken as the same requirement is true for perf.
> 
> Signed-off-by: Richard Cochran <[email protected]>
> Reviewed-by: Sebastian Andrzej Siewior <[email protected]>
> Cc: Jason Cooper <[email protected]>
> Cc: Marc Zyngier <[email protected]>
> Signed-off-by: Anna-Maria Gleixner <[email protected]>

The SOB sequence is unusal. Is this patch missing this line:

  From: Richard Cochran <[email protected]>

... or should the SOB be:

  Acked-by: Richard Cochran <[email protected]>

?

Thanks,

        Ingo

Reply via email to