On Tue, Jul 12, 2016 at 06:20:06PM +0530, Goel, Akash wrote: > Thanks much, will update the documentation as well as the changelog > as per the above. > > But an export of symbol relay_late_setup_files() is still needed, just > like relay_open() is exported, in order to make it accessible to > modules like i915 ?
Yes, we need the companion function in i915.ko. That needs to be explained in the patch notes to justify adding the EXPORT_SYMBOL. Otherwise without that context, it looks unnecessary as Andrew objected to. -Chris -- Chris Wilson, Intel Open Source Technology Centre