From: Markus Elfring <[email protected]>
Date: Tue, 19 Jul 2016 22:42:22 +0200

The of_node_put() function tests whether its argument is NULL
and then returns immediately.
Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
 drivers/of/base.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index a4b6087..2601167 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1609,8 +1609,7 @@ static int __of_parse_phandle_with_args(const struct 
device_node *np,
         */
 
  err:
-       if (it.node)
-               of_node_put(it.node);
+       of_node_put(it.node);
        return rc;
 }
 
-- 
2.9.2

Reply via email to