> > On Mon, Jul 18, 2016 at 4:27 PM, Tomas Winkler <[email protected]> > wrote: > > The user space API is achieved via two synchronous IOCTL. > > Simplified one, RPMB_IOC_REQ_CMD, were read result cycles is > performed > > by the framework on behalf the user and second, RPMB_IOC_SEQ_CMD > where > > the whole RPMB sequence including RESULT_READ is supplied by the caller. > > The latter is intended for easier adjusting of the applications > > that use MMC_IOC_MULTI_CMD ioctl. > > > > Signed-off-by: Tomas Winkler <[email protected]> > > --- > > [...] > > > diff --git a/drivers/char/rpmb/Kconfig b/drivers/char/rpmb/Kconfig > > index c5e6e909efce..6794be9fcc5e 100644 > > --- a/drivers/char/rpmb/Kconfig > > +++ b/drivers/char/rpmb/Kconfig > > @@ -6,3 +6,10 @@ config RPMB > > access RPMB partition. > > > > If unsure, select N. > > + > > +config RPMB_INTF_DEV > > + bool "RPMB character device interface /dev/rpmbN" > > A bool Kconfig should ideally.... > > > + depends on RPMB > > + help > > + Say yes here if you want to access RPMB from user space > > + via character device interface /dev/rpmb%d > > diff --git a/drivers/char/rpmb/Makefile b/drivers/char/rpmb/Makefile > > index 812b3ed264c0..b5dc087b1299 100644 > > --- a/drivers/char/rpmb/Makefile > > +++ b/drivers/char/rpmb/Makefile > > @@ -1,4 +1,5 @@ > > obj-$(CONFIG_RPMB) += rpmb.o > > rpmb-objs += core.o > > +rpmb-$(CONFIG_RPMB_INTF_DEV) += cdev.o
This is not a builtin, this is an optional part of the module > > +#include <linux/module.h> > > ....not use module.h or any MODULE_ macros from within it. Can be dropped in this case as no macros are used, but the pattern Kconfig bool -> no include module.h you are following has false positive cases. Thanks Tomas
