On Sun, Jul 24, 2016 at 9:20 AM, Max Filippov <[email protected]> wrote: > On Sun, Jul 24, 2016 at 9:00 AM, Guenter Roeck <[email protected]> wrote: >> On 07/23/2016 05:45 PM, Max Filippov wrote: >>> >>> On Sun, Jul 24, 2016 at 3:24 AM, Guenter Roeck <[email protected]> wrote: >>>> >>>> Commit 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate >>>> with default match table") dropped various include files from >>>> arch/xtensa/kernel/setup.c. This results in the following build error. >>>> >>>> arch/xtensa/kernel/setup.c: In function ‘xtensa_dt_io_area’: >>>> arch/xtensa/kernel/setup.c:213:2: error: >>>> implicit declaration of function ‘of_read_ulong’ >>>> >>>> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate >>>> with default match table") >>>> Cc: Kefeng Wang <[email protected]> >>>> Cc: Rob Herring <[email protected]> >>>> Signed-off-by: Guenter Roeck <[email protected]> >>>> --- >>>> I would suggest to merge this patch into the commit causing the problem >>>> if possible. >>>> >>>> arch/xtensa/kernel/setup.c | 1 + >>>> 1 file changed, 1 insertion(+) >>> >>> >>> Acked-by: Max Filippov <[email protected]> >>> >> >> Heads up: xtensa images build after this patch, but the image that >> previously failed to build (generic_kc705_defconfig) doesn't boot, >> at least not with qemu. I don't know if this is caused by 69d99e6c0d621f >> or by some other patch. > > It seems to be booting, but serial console is non-functional. > With commit 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate > with default match table") I see the following message during boot: > > [ 6.375284] of_serial fd050020.serial: clk or clock-frequency not defined > > Reverting that commit fixes serial console for me. > Any suggestions on what might go wrong?
Probably the init order changed somehow and deferred probe is not supported correctly. Rob
