On Mon, Jul 25, 2016 at 11:14:11AM -0700, Brian Norris wrote: > cros_ec_cmd_xfer returns success status if the command transport > completes successfully, but the execution result is incorrectly ignored. > In many cases, the execution result is assumed to be successful, leading > to ignored errors and operating on uninitialized data. > > We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these > problems. Let's use it. > > Signed-off-by: Brian Norris <[email protected]>
Instead of me pulling in pwm/mfd branch maybe Thierry can push through his branch? Acked-by: Dmitry Torokhov <[email protected]> > --- > drivers/input/keyboard/cros_ec_keyb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c > b/drivers/input/keyboard/cros_ec_keyb.c > index b01966dc7eb3..6e48616a3a88 100644 > --- a/drivers/input/keyboard/cros_ec_keyb.c > +++ b/drivers/input/keyboard/cros_ec_keyb.c > @@ -160,7 +160,7 @@ static int cros_ec_keyb_get_state(struct cros_ec_keyb > *ckdev, uint8_t *kb_state) > msg->insize = ckdev->cols; > msg->outsize = 0; > > - ret = cros_ec_cmd_xfer(ckdev->ec, msg); > + ret = cros_ec_cmd_xfer_status(ckdev->ec, msg); > if (ret < 0) { > dev_err(ckdev->dev, "Error transferring EC message %d\n", ret); > goto exit; > -- > 2.8.0.rc3.226.g39d4020 > -- Dmitry
