Before, signoff was not checked if the filename is '-', indicating reading the patch from stdin. This causes commands such as below not to warn about a missing signoff.
git show --pretty=email | scripts/checkpatch.pl - As a workaround, the command could be modified to refer to stdin by a name other than '-'. The workaround is not an elegant solution, because elsewhere checkpatch uses the fact that filename equals '-' is special for stdin, such as setting '$vname' to 'Your patch'. git show --pretty=email | scripts/checkpatch.pl /dev/stdin This change causes checkpatch to check for a missing signoff line, even if the filename is '-', as in the first variation of the command. Signed-off-by: Allen Hubbe <[email protected]> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4904ced676d4..83acbac10705 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6045,7 +6045,7 @@ sub process { ERROR("NOT_UNIFIED_DIFF", "Does not appear to be a unified-diff format patch\n"); } - if ($is_patch && $filename ne '-' && $chk_signoff && $signoff == 0) { + if ($is_patch && $chk_signoff && $signoff == 0) { ERROR("MISSING_SIGN_OFF", "Missing Signed-off-by: line(s)\n"); } -- 2.9.1
