On Wed, Jun 29, 2016 at 09:27:40PM +0100, Luis de Bethencourt wrote:
> Log error only when silent flag is not set.
>
> Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging
> errors")
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
>
> Hi,
>
> Reading the backlog of latest patches to befs, I noticed that Salah's patch
> missed one call to befs_error() when setting all to only be used when the
> silent argument is false.
>
> Thanks,
> Luis
>
> fs/befs/linuxvfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
> index b700645..bf5658d 100644
> --- a/fs/befs/linuxvfs.c
> +++ b/fs/befs/linuxvfs.c
> @@ -790,7 +790,8 @@ befs_fill_super(struct super_block *sb, void *data, int
> silent)
> */
> blocksize = sb_min_blocksize(sb, 1024);
> if (!blocksize) {
> - befs_error(sb, "unable to set blocksize");
> + if (!silent)
> + befs_error(sb, "unable to set blocksize");
> goto unacquire_priv_sbp;
> }
>
> --
> 2.5.1
>
Acked-by: Salah Triki <[email protected]>
regards,
salah
