I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- arch/s390/kernel/topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c index 64298a8..1d2d2e1 100644 --- a/arch/s390/kernel/topology.c +++ b/arch/s390/kernel/topology.c @@ -380,7 +380,7 @@ out: put_online_cpus(); return rc ? rc : count; } -static DEVICE_ATTR(dispatching, 0644, dispatching_show, +static DEVICE_ATTR(dispatching, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, dispatching_show, dispatching_store); static ssize_t cpu_polarization_show(struct device *dev, @@ -410,7 +410,7 @@ static ssize_t cpu_polarization_show(struct device *dev, mutex_unlock(&smp_cpu_state_mutex); return count; } -static DEVICE_ATTR(polarization, 0444, cpu_polarization_show, NULL); +static DEVICE_ATTR(polarization, S_IRUSR | S_IRGRP | S_IROTH, cpu_polarization_show, NULL); static struct attribute *topology_cpu_attrs[] = { &dev_attr_polarization.attr, -- 2.9.2
