I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/edac/i5000_edac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c index 72e07e3..f87698e 100644 --- a/drivers/edac/i5000_edac.c +++ b/drivers/edac/i5000_edac.c @@ -1587,8 +1587,8 @@ MODULE_AUTHOR MODULE_DESCRIPTION("MC Driver for Intel I5000 memory controllers - " I5000_REVISION); -module_param(edac_op_state, int, 0444); +module_param(edac_op_state, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(edac_op_state, "EDAC Error Reporting state: 0=Poll,1=NMI"); -module_param(misc_messages, int, 0444); +module_param(misc_messages, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(misc_messages, "Log miscellaneous non fatal messages"); -- 2.9.2
