I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/gpio/gpio-cs5535.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-cs5535.c b/drivers/gpio/gpio-cs5535.c index 90278b1..b17c3f9 100644 --- a/drivers/gpio/gpio-cs5535.c +++ b/drivers/gpio/gpio-cs5535.c @@ -39,7 +39,7 @@ #define GPIO_DEFAULT_MASK 0x0F7FFFFF static ulong mask = GPIO_DEFAULT_MASK; -module_param_named(mask, mask, ulong, 0444); +module_param_named(mask, mask, ulong, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(mask, "GPIO channel mask."); /* -- 2.9.2
