I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/pci/cx88/cx88-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-core.c b/drivers/media/pci/cx88/cx88-core.c index 46fe8c1..6125b9e 100644 --- a/drivers/media/pci/cx88/cx88-core.c +++ b/drivers/media/pci/cx88/cx88-core.c @@ -49,15 +49,15 @@ MODULE_LICENSE("GPL"); /* ------------------------------------------------------------------ */ unsigned int cx88_core_debug; -module_param_named(core_debug, cx88_core_debug, int, 0644); +module_param_named(core_debug, cx88_core_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(core_debug, "enable debug messages [core]"); static unsigned int nicam; -module_param(nicam,int,0644); +module_param(nicam,int,S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(nicam,"tv audio is nicam"); static unsigned int nocomb; -module_param(nocomb,int,0644); +module_param(nocomb,int,S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(nocomb,"disable comb filter"); #define dprintk(level,fmt, arg...) do { \ -- 2.9.2
