I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/pci/saa7134/saa7134-ts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-ts.c b/drivers/media/pci/saa7134/saa7134-ts.c index 0584a2a..36db56d 100644 --- a/drivers/media/pci/saa7134/saa7134-ts.c +++ b/drivers/media/pci/saa7134/saa7134-ts.c @@ -32,7 +32,7 @@ /* ------------------------------------------------------------------ */ static unsigned int ts_debug; -module_param(ts_debug, int, 0644); +module_param(ts_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ts_debug,"enable debug messages [ts]"); #define ts_dbg(fmt, arg...) do { \ @@ -190,11 +190,11 @@ EXPORT_SYMBOL_GPL(saa7134_ts_qops); /* exported stuff */ static unsigned int tsbufs = 8; -module_param(tsbufs, int, 0444); +module_param(tsbufs, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(tsbufs, "number of ts buffers for read/write IO, range 2-32"); static unsigned int ts_nr_packets = 64; -module_param(ts_nr_packets, int, 0444); +module_param(ts_nr_packets, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ts_nr_packets,"size of a ts buffers (in ts packets)"); int saa7134_ts_init_hw(struct saa7134_dev *dev) -- 2.9.2
