I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/tuners/tuner-simple.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/tuners/tuner-simple.c b/drivers/media/tuners/tuner-simple.c index 8e9ce14..7218a7e 100644 --- a/drivers/media/tuners/tuner-simple.c +++ b/drivers/media/tuners/tuner-simple.c @@ -14,22 +14,22 @@ #include "tuner-simple.h" static int debug; -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "enable verbose debug messages"); #define TUNER_SIMPLE_MAX 64 static unsigned int simple_devcount; static int offset; -module_param(offset, int, 0664); +module_param(offset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH); MODULE_PARM_DESC(offset, "Allows to specify an offset for tuner"); static unsigned int atv_input[TUNER_SIMPLE_MAX] = \ { [0 ... (TUNER_SIMPLE_MAX-1)] = 0 }; static unsigned int dtv_input[TUNER_SIMPLE_MAX] = \ { [0 ... (TUNER_SIMPLE_MAX-1)] = 0 }; -module_param_array(atv_input, int, NULL, 0644); -module_param_array(dtv_input, int, NULL, 0644); +module_param_array(atv_input, int, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_array(dtv_input, int, NULL, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(atv_input, "specify atv rf input, 0 for autoselect"); MODULE_PARM_DESC(dtv_input, "specify dtv rf input, 0 for autoselect"); -- 2.9.2
