I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/pci/bt8xx/dst.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/pci/bt8xx/dst.c b/drivers/media/pci/bt8xx/dst.c index 35bc9b2..83519d9 100644 --- a/drivers/media/pci/bt8xx/dst.c +++ b/drivers/media/pci/bt8xx/dst.c @@ -31,15 +31,15 @@ #include "dst_common.h" static unsigned int verbose = 1; -module_param(verbose, int, 0644); +module_param(verbose, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(verbose, "verbose startup messages, default is 1 (yes)"); static unsigned int dst_addons; -module_param(dst_addons, int, 0644); +module_param(dst_addons, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(dst_addons, "CA daughterboard, default is 0 (No addons)"); static unsigned int dst_algo; -module_param(dst_algo, int, 0644); +module_param(dst_algo, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(dst_algo, "tuning algo: default is 0=(SW), 1=(HW)"); #define HAS_LOCK 1 -- 2.9.2
