I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- fs/fuse/inode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 1ce6766..da16107 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c @@ -33,7 +33,7 @@ static int set_global_limit(const char *val, struct kernel_param *kp); unsigned max_user_bgreq; module_param_call(max_user_bgreq, set_global_limit, param_get_uint, - &max_user_bgreq, 0644); + &max_user_bgreq, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); __MODULE_PARM_TYPE(max_user_bgreq, "uint"); MODULE_PARM_DESC(max_user_bgreq, "Global limit for the maximum number of backgrounded requests an " @@ -41,7 +41,7 @@ MODULE_PARM_DESC(max_user_bgreq, unsigned max_user_congthresh; module_param_call(max_user_congthresh, set_global_limit, param_get_uint, - &max_user_congthresh, 0644); + &max_user_congthresh, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); __MODULE_PARM_TYPE(max_user_congthresh, "uint"); MODULE_PARM_DESC(max_user_congthresh, "Global limit for the maximum congestion threshold an " -- 2.9.2
