I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the
corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng....@intel.com>
Signed-off-by: Baole Ni <baolex...@intel.com>
---
kernel/irq/spurious.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
index 5707f97..718f551 100644
--- a/kernel/irq/spurious.c
+++ b/kernel/irq/spurious.c
@@ -437,7 +437,7 @@ int noirqdebug_setup(char *str)
}
__setup("noirqdebug", noirqdebug_setup);
-module_param(noirqdebug, bool, 0644);
+module_param(noirqdebug, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
MODULE_PARM_DESC(noirqdebug, "Disable irq lockup detection when true");
static int __init irqfixup_setup(char *str)
@@ -450,7 +450,7 @@ static int __init irqfixup_setup(char *str)
}
__setup("irqfixup", irqfixup_setup);
-module_param(irqfixup, int, 0644);
+module_param(irqfixup, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
static int __init irqpoll_setup(char *str)
{
--
2.9.2
