On Tue, 2 Aug 2016 20:14:48 +0800 Baole Ni <[email protected]> wrote:
> I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu <[email protected]> > Signed-off-by: Baole Ni <[email protected]> > --- > mm/zswap.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 275b22c..aede3ee 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -78,7 +78,7 @@ static u64 zswap_duplicate_entry; > > /* Enable/disable zswap (disabled by default) */ > static bool zswap_enabled; > -module_param_named(enabled, zswap_enabled, bool, 0644); > +module_param_named(enabled, zswap_enabled, bool, S_IRUSR | S_IWUSR | S_IRGRP > | S_IROTH); > > /* Crypto compressor to use */ > #define ZSWAP_COMPRESSOR_DEFAULT "lzo" > @@ -91,7 +91,7 @@ static struct kernel_param_ops zswap_compressor_param_ops = > { > .free = param_free_charp, > }; > module_param_cb(compressor, &zswap_compressor_param_ops, > - &zswap_compressor, 0644); > + &zswap_compressor, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > /* Compressed storage zpool to use */ > #define ZSWAP_ZPOOL_DEFAULT "zbud" > @@ -102,11 +102,11 @@ static struct kernel_param_ops zswap_zpool_param_ops = { > .get = param_get_charp, > .free = param_free_charp, > }; > -module_param_cb(zpool, &zswap_zpool_param_ops, &zswap_zpool_type, 0644); > +module_param_cb(zpool, &zswap_zpool_param_ops, &zswap_zpool_type, S_IRUSR | > S_IWUSR | S_IRGRP | S_IROTH); > > /* The maximum percentage of memory that the compressed pool can occupy */ > static unsigned int zswap_max_pool_percent = 20; > -module_param_named(max_pool_percent, zswap_max_pool_percent, uint, 0644); > +module_param_named(max_pool_percent, zswap_max_pool_percent, uint, S_IRUSR | > S_IWUSR | S_IRGRP | S_IROTH); > > /********************************* > * data structures
