On Tue, 2 Aug 2016 20:15:02 +0800 Baole Ni <[email protected]> wrote:
> I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu <[email protected]> > Signed-off-by: Baole Ni <[email protected]> > --- > net/802/mrp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/802/mrp.c b/net/802/mrp.c > index 72db278..4ff215f 100644 > --- a/net/802/mrp.c > +++ b/net/802/mrp.c > @@ -22,11 +22,11 @@ > #include <asm/unaligned.h> > > static unsigned int mrp_join_time __read_mostly = 200; > -module_param(mrp_join_time, uint, 0644); > +module_param(mrp_join_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(mrp_join_time, "Join time in ms (default 200ms)"); > > static unsigned int mrp_periodic_time __read_mostly = 1000; > -module_param(mrp_periodic_time, uint, 0644); > +module_param(mrp_periodic_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(mrp_periodic_time, "Periodic time in ms (default 1s)"); > > MODULE_LICENSE("GPL");
