I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- net/wimax/stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wimax/stack.c b/net/wimax/stack.c index 3f816e2..084ce9a 100644 --- a/net/wimax/stack.c +++ b/net/wimax/stack.c @@ -64,7 +64,7 @@ static char wimax_debug_params[128]; module_param_string(debug, wimax_debug_params, sizeof(wimax_debug_params), - 0644); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "String of space-separated NAME:VALUE pairs, where NAMEs " "are the different debug submodules and VALUE are the " -- 2.9.2
