I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- init/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index 4c17fda..7d9e25d 100644 --- a/init/main.c +++ b/init/main.c @@ -674,7 +674,7 @@ static void __init do_ctors(void) } bool initcall_debug; -core_param(initcall_debug, initcall_debug, bool, 0644); +core_param(initcall_debug, initcall_debug, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #ifdef CONFIG_KALLSYMS struct blacklist_entry { -- 2.9.2
