I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- kernel/debug/debug_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index 0874e2e..2716f17 100644 --- a/kernel/debug/debug_core.c +++ b/kernel/debug/debug_core.c @@ -102,8 +102,8 @@ static int __init opt_kgdb_con(char *str) early_param("kgdbcon", opt_kgdb_con); -module_param(kgdb_use_con, int, 0644); -module_param(kgdbreboot, int, 0644); +module_param(kgdb_use_con, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(kgdbreboot, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* * Holds information about breakpoints in a kernel. These breakpoints are -- 2.9.2
