I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/pci/cx23885/cimax2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx23885/cimax2.c b/drivers/media/pci/cx23885/cimax2.c index 631e4f2..d1a75e1 100644 --- a/drivers/media/pci/cx23885/cimax2.c +++ b/drivers/media/pci/cx23885/cimax2.c @@ -58,11 +58,11 @@ #define NETUP_IRQ_IRQAM 0x4 static unsigned int ci_dbg; -module_param(ci_dbg, int, 0644); +module_param(ci_dbg, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ci_dbg, "Enable CI debugging"); static unsigned int ci_irq_enable; -module_param(ci_irq_enable, int, 0644); +module_param(ci_irq_enable, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ci_irq_enable, "Enable IRQ from CAM"); #define ci_dbg_print(args...) \ -- 2.9.2
