I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/mtd/mtdswap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index cb06bdd..741b9e0 100644 --- a/drivers/mtd/mtdswap.c +++ b/drivers/mtd/mtdswap.c @@ -180,17 +180,17 @@ enum { #define MTDSWAP_MBD_TO_MTDSWAP(dev) ((struct mtdswap_dev *)dev->priv) static char partitions[128] = ""; -module_param_string(partitions, partitions, sizeof(partitions), 0444); +module_param_string(partitions, partitions, sizeof(partitions), S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(partitions, "MTD partition numbers to use as swap " "partitions=\"1,3,5\""); static unsigned int spare_eblocks = 10; -module_param(spare_eblocks, uint, 0444); +module_param(spare_eblocks, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(spare_eblocks, "Percentage of spare erase blocks for " "garbage collection (default 10%)"); static bool header; /* false */ -module_param(header, bool, 0444); +module_param(header, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(header, "Include builtin swap header (default 0, without header)"); -- 2.9.2
