I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/memstick/host/tifm_ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c index 7bafa72..dd474a9 100644 --- a/drivers/memstick/host/tifm_ms.c +++ b/drivers/memstick/host/tifm_ms.c @@ -23,7 +23,7 @@ #define DRIVER_NAME "tifm_ms" static bool no_dma; -module_param(no_dma, bool, 0644); +module_param(no_dma, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* * Some control bits of TIFM appear to conform to Sony's reference design, -- 2.9.2
