There are so many of these, I wonder if it'd be better to just do one giant patch, or at least break them up by subsystem instead of by individual source file...
-Kees On Tue, Aug 2, 2016 at 4:11 AM, Baole Ni <[email protected]> wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <[email protected]> > Signed-off-by: Baole Ni <[email protected]> > --- > drivers/media/i2c/tvp5150.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c > index 0b6d46c..d8ffd88 100644 > --- a/drivers/media/i2c/tvp5150.c > +++ b/drivers/media/i2c/tvp5150.c > @@ -33,7 +33,7 @@ MODULE_LICENSE("GPL"); > > > static int debug; > -module_param(debug, int, 0644); > +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(debug, "Debug level (0-2)"); > > struct tvp5150 { > -- > 2.9.2 > -- Kees Cook Chrome OS & Brillo Security
