I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/infiniband/hw/cxgb4/device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c index ae2e8b2..e974afb 100644 --- a/drivers/infiniband/hw/cxgb4/device.c +++ b/drivers/infiniband/hw/cxgb4/device.c @@ -47,21 +47,21 @@ MODULE_LICENSE("Dual BSD/GPL"); MODULE_VERSION(DRV_VERSION); static int allow_db_fc_on_t5; -module_param(allow_db_fc_on_t5, int, 0644); +module_param(allow_db_fc_on_t5, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(allow_db_fc_on_t5, "Allow DB Flow Control on T5 (default = 0)"); static int allow_db_coalescing_on_t5; -module_param(allow_db_coalescing_on_t5, int, 0644); +module_param(allow_db_coalescing_on_t5, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(allow_db_coalescing_on_t5, "Allow DB Coalescing on T5 (default = 0)"); int c4iw_wr_log = 0; -module_param(c4iw_wr_log, int, 0444); +module_param(c4iw_wr_log, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(c4iw_wr_log, "Enables logging of work request timing data."); static int c4iw_wr_log_size_order = 12; -module_param(c4iw_wr_log_size_order, int, 0444); +module_param(c4iw_wr_log_size_order, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(c4iw_wr_log_size_order, "Number of entries (log2) in the work request timing log."); -- 2.9.2
