I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/pci/cx88/cx88-input.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-input.c b/drivers/media/pci/cx88/cx88-input.c index 3f1342c..e813667 100644 --- a/drivers/media/pci/cx88/cx88-input.c +++ b/drivers/media/pci/cx88/cx88-input.c @@ -58,11 +58,11 @@ struct cx88_IR { }; static unsigned ir_samplerate = 4; -module_param(ir_samplerate, uint, 0444); +module_param(ir_samplerate, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(ir_samplerate, "IR samplerate in kHz, 1 - 20, default 4"); static int ir_debug; -module_param(ir_debug, int, 0644); /* debug level [IR] */ +module_param(ir_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* debug level [IR] */ MODULE_PARM_DESC(ir_debug, "enable debug messages [IR]"); #define ir_dprintk(fmt, arg...) if (ir_debug) \ -- 2.9.2
