I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/i2c/m5mols/m5mols_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/m5mols/m5mols_core.c b/drivers/media/i2c/m5mols/m5mols_core.c index acb804b..df6499e 100644 --- a/drivers/media/i2c/m5mols/m5mols_core.c +++ b/drivers/media/i2c/m5mols/m5mols_core.c @@ -31,7 +31,7 @@ #include "m5mols_reg.h" int m5mols_debug; -module_param(m5mols_debug, int, 0644); +module_param(m5mols_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define MODULE_NAME "M5MOLS" #define M5MOLS_I2C_CHECK_RETRY 500 -- 2.9.2
