I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/edac/amd64_edac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 46784eb..2ebc7a5 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -4,14 +4,14 @@ static struct edac_pci_ctl_info *pci_ctl; static int report_gart_errors; -module_param(report_gart_errors, int, 0644); +module_param(report_gart_errors, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* * Set by command line parameter. If BIOS has enabled the ECC, this override is * cleared to prevent re-enabling the hardware by this driver. */ static int ecc_enable_override; -module_param(ecc_enable_override, int, 0644); +module_param(ecc_enable_override, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static struct msr __percpu *msrs; @@ -3037,5 +3037,5 @@ MODULE_AUTHOR("SoftwareBitMaker: Doug Thompson, " MODULE_DESCRIPTION("MC support for AMD64 memory controllers - " EDAC_AMD64_VERSION); -module_param(edac_op_state, int, 0444); +module_param(edac_op_state, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(edac_op_state, "EDAC Error Reporting state: 0=Poll,1=NMI"); -- 2.9.2
