I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/hid/hid-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 8ea3a26..ad11fb2 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -46,12 +46,12 @@ #define DRIVER_LICENSE "GPL" int hid_debug = 0; -module_param_named(debug, hid_debug, int, 0600); +module_param_named(debug, hid_debug, int, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(debug, "toggle HID debugging messages"); EXPORT_SYMBOL_GPL(hid_debug); static int hid_ignore_special_drivers = 0; -module_param_named(ignore_special_drivers, hid_ignore_special_drivers, int, 0600); +module_param_named(ignore_special_drivers, hid_ignore_special_drivers, int, S_IRUSR | S_IWUSR); MODULE_PARM_DESC(ignore_special_drivers, "Ignore any special drivers and handle all devices by generic driver"); /* -- 2.9.2
