I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- block/genhd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/genhd.c b/block/genhd.c index 9f42526..1079e623 100644 --- a/block/genhd.c +++ b/block/genhd.c @@ -1807,7 +1807,7 @@ static const struct kernel_param_ops disk_events_dfl_poll_msecs_param_ops = { #define MODULE_PARAM_PREFIX "block." module_param_cb(events_dfl_poll_msecs, &disk_events_dfl_poll_msecs_param_ops, - &disk_events_dfl_poll_msecs, 0644); + &disk_events_dfl_poll_msecs, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); /* * disk_{alloc|add|del|release}_events - initialize and destroy disk_events. -- 2.9.2
