I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- arch/powerpc/platforms/cell/cbe_thermal.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/cell/cbe_thermal.c b/arch/powerpc/platforms/cell/cbe_thermal.c index 2c15ff0..39bc790 100644 --- a/arch/powerpc/platforms/cell/cbe_thermal.c +++ b/arch/powerpc/platforms/cell/cbe_thermal.c @@ -254,9 +254,9 @@ static struct device_attribute attr_spu_temperature = { .show = spu_show_temp, }; -static DEVICE_PREFIX_ATTR(spu, throttle_end, 0600); -static DEVICE_PREFIX_ATTR(spu, throttle_begin, 0600); -static DEVICE_PREFIX_ATTR(spu, throttle_full_stop, 0600); +static DEVICE_PREFIX_ATTR(spu, throttle_end, S_IRUSR | S_IWUSR); +static DEVICE_PREFIX_ATTR(spu, throttle_begin, S_IRUSR | S_IWUSR); +static DEVICE_PREFIX_ATTR(spu, throttle_full_stop, S_IRUSR | S_IWUSR); static struct attribute *spu_attributes[] = { @@ -282,9 +282,9 @@ static struct device_attribute attr_ppe_temperature1 = { .show = ppe_show_temp1, }; -static DEVICE_PREFIX_ATTR(ppe, throttle_end, 0600); -static DEVICE_PREFIX_ATTR(ppe, throttle_begin, 0600); -static DEVICE_PREFIX_ATTR(ppe, throttle_full_stop, 0600); +static DEVICE_PREFIX_ATTR(ppe, throttle_end, S_IRUSR | S_IWUSR); +static DEVICE_PREFIX_ATTR(ppe, throttle_begin, S_IRUSR | S_IWUSR); +static DEVICE_PREFIX_ATTR(ppe, throttle_full_stop, S_IRUSR | S_IWUSR); static struct attribute *ppe_attributes[] = { &attr_ppe_temperature0.attr, -- 2.9.2
