On Tue, Aug 02, 2016 at 11:18:57PM -0400, Steven Rostedt wrote: > On Tue, 2 Aug 2016 22:12:33 -0500 > Josh Poimboeuf <[email protected]> wrote: > > > > Sounds good. I was thinking I could also add a similar define to > > indicate whether an arch passes the return address stack pointer to > > ftrace_push_return_trace(). HAVE_FUNCTION_GRAPH_RET_ADDR_PTR? > > > > If you are making this function global, might as well make all pass > that pointer when you do the conversion. I don't think we need a define > to differentiate it.
In theory, I like the idea. But from what I can tell, it looks like a few arches would require some assembly changes: s390, powerpc, and sparc. I can probably handle s390 and power, but sparc is a whole different story... -- Josh
