On 08/17/2016 11:33 PM, Felipe Balbi wrote:

Hi,

Peter Chen <[email protected]> writes:
On Wed, Aug 17, 2016 at 03:53:24PM +0300, Felipe Balbi wrote:

Hi,

Heikki Krogerus <[email protected]> writes:

[...]

+static struct platform_driver wcove_typec_driver = {
+       .driver = {
+               .name           = "bxt_wcove_usbc",
+       },
+       .probe                  = wcove_typec_probe,
+       .remove                 = wcove_typec_remove,
+};
+
+module_platform_driver(wcove_typec_driver);
+
+MODULE_AUTHOR("Intel Corporation");
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("WhiskeyCove PMIC USB Type-C PHY driver");

you need to add:

MODULE_ALIAS("platform:bxt_wcove_usbc");

otherwise this won't probe() automagically.


What do you mean, Felipe? If there is a platform device named
"bxt_wcove_usbc", why it will not be probed?

IIRC default module alias is added based on file name, not
platform_driver name, so this would be
MODULE_ALIAS("platform:typec_wcove") by default... I could be wrong,
really don't remember the details of  that now.

AFAIK one either needs MODULE_ALIAS or MODULE_DEVICE_TABLE for platform
device autoloading. I have seen many patches along the line of "Add missing
MODULE_ALIAS", so I'd be a bit surprised if that was no longer needed.

Guenter

Reply via email to