Make the probability of ftrace dump not interfering with other writers grace period, HZ independent.
Signed-off-by: Nicholas Mc Guire <[email protected]> --- Problem found by coccinelle script Passing in jiffies as value allows for this "fixed" delay varying by one order of magnitude. As it is intended to reduce the probability of interference this probability should not be dependent on the systems HZ setting. Its probably more cosmetic but I guess this is the cleaner way for fixed delays. Q: Could not really figure out why the _interruptible_ version is used here - I would assume that schedule_timeout() would be what is needed here, as this should simply be a fixed delay. Patch was compile tested with: x86_64_defconfig + CONFIG_RCU_PERF_TEST=m Patch is against 4.8.0-rc2 (localversion-next is -next-20160822) kernel/rcu/rcuperf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c index 123ccbd..4cd8655 100644 --- a/kernel/rcu/rcuperf.c +++ b/kernel/rcu/rcuperf.c @@ -404,7 +404,8 @@ rcu_perf_writer(void *arg) perf_type, PERF_FLAG, me, MIN_MEAS); if (atomic_inc_return(&n_rcu_perf_writer_finished) >= nrealwriters) { - schedule_timeout_interruptible(10); + schedule_timeout_interruptible( + msecs_to_jiffies(10)); rcu_ftrace_dump(DUMP_ALL); PERFOUT_STRING("Test complete"); t_rcu_perf_writer_finished = t; -- 2.1.4
