On Thu, Feb 15, 2007 at 02:27:45AM -0800, Andrew Morton wrote:
>
> Judging from the patch headers you were working against 2.6.19, which is
> most optimistic. Please always prepare and test patches against the
> latest kernel.
Well, I had it applied against a 2.6.20 kernel, but I messed up the
testing of it. Sorry, my bad.
New patch...
Add pci_remove handling to the driver, so it will clean up if
the device is hot-removed.
Signed-off-by: Corey Minyard <[EMAIL PROTECTED]>
Index: linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux-2.6.20.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6.20/drivers/char/ipmi/ipmi_si_intf.c
@@ -2191,12 +2191,15 @@ static int __devinit ipmi_pci_probe(stru
info->irq_setup = std_irq_setup;
info->dev = &pdev->dev;
+ pdev->dev.driver_data = info;
return try_smi_init(info);
}
static void __devexit ipmi_pci_remove(struct pci_dev *pdev)
{
+ struct smi_info *info = pdev->dev.driver_data;
+ cleanup_one_si(info);
}
#ifdef CONFIG_PM
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
