> @@ -407,32 +410,39 @@ static inline int tegra_i2c_clock_enable(struct 
> tegra_i2c_dev *i2c_dev)
>                       return ret;
>               }
>       }
> +
>       ret = clk_enable(i2c_dev->div_clk);
>       if (ret < 0) {
>               dev_err(i2c_dev->dev,
>                       "Enabling div clk failed, err %d\n", ret);
>               clk_disable(i2c_dev->fast_clk);
> +             return ret;
>       }
> -     return ret;
> +
> +     return 0;

You could have left the original 'return' instead of the 2 new ones, but
you decide.

> -     if (tegra_i2c_flush_fifos(i2c_dev))
> -             err = -ETIMEDOUT;
> +     err = tegra_i2c_flush_fifos(i2c_dev);

'err' is assigned but where is it checked?

I'll apply patches 1-4 meanwhile.

Attachment: signature.asc
Description: PGP signature

Reply via email to