Re: [PATCH 2/2] f2fs: fix to update node page under cp_rwsem

[Jaegeuk Kim]

On Sat, Aug 27, 2016 at 12:14:32AM +0800, Chao Yu wrote:
> From: Chao Yu <yuch...@huawei.com>
> 
> Update node page under cp_rwsem in order to keep data consistency
> during writting checkpoint.
> 
> Signed-off-by: Chao Yu <yuch...@huawei.com>
> ---
>  fs/f2fs/inode.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index 9ac5efc..1057c73 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -377,8 +377,11 @@ retry:
>               goto retry;
>       }
>  
> -     if (err)
> +     if (err) {
> +             f2fs_lock_op(sbi);
>               update_inode_page(inode);
> +             f2fs_unlock_op(sbi);
> +     }

Any corner case?
Now, it allows updating node page when checkpoint is doing.

Thanks,

>       sb_end_intwrite(inode->i_sb);
>  no_delete:
>       stat_dec_inline_xattr(inode);
> -- 
> 2.7.2