Rodolfo Giometti wrote: >>> +PROCFS support >>> +-------------- >> New features shouldn't introduce new /proc stuff. > > It's a must? I can leave procfs for backward compatibility with old > utilities?
Hmm, as this is a new feature with regard to the mainline kernel, old utilities don't count (if you can install a new kernel you can also be expected to install new user-space tools for the new feature). >> You read the comment above your line? > > No, sorry. I'm going to choose another id number... or can I keep 17? I don't know, ask whoever is responsible for the file. >>> +#define to_class_dev(obj) container_of((obj), struct class_device, kobj) >> pretty generic name. > > I should change it? If it's of general use put it in the appropriate header file. If it's just for the pps subsystem name it as such. >> Have you thought about 32/64bit issues? > > No. I have no 64 bits machine to test the code... Hmm, think about x86_64 with 64-bit kernel and 32-bit userspace, probably having got different padding in the struct. Read LDD3, chapter 11, especially 11.4 . Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/