Hi Ben, Pan

This is a second ping.

Will appreciate your feedback wither changing syntax will do the change or that 
I need a different approach to achieve such enhancement.
See below for new syntax suggestion.

-Noam 

-----Original Message-----
From: Noam Camus 
Sent: Monday, August 01, 2016 7:53 AM
To: 'Pan Xinhui' <[email protected]>; '[email protected]' 
<[email protected]>; 'Ben Hutchings' <[email protected]>
Cc: '[email protected]' <[email protected]>; '[email protected]' 
<[email protected]>; '[email protected]' <[email protected]>; 
'[email protected]' <[email protected]>
Subject: RE: [PATCH v3] lib/bitmap.c: enhance bitmap syntax

Ping...

-----Original Message-----
From: Noam Camus 
Sent: Monday, July 18, 2016 10:06 AM
To: Pan Xinhui <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; [email protected]; 
[email protected]
Subject: RE: [PATCH v3] lib/bitmap.c: enhance bitmap syntax

> From: Pan Xinhui [mailto:[email protected]]
> Sent: Sunday, July 17, 2016 4:59 PM

>>
>> I really think it is better to implement one function to generic a string 
>> which contanis the cpus you want to boot on, then pass this string to  
>> __bitmap_parselist.
>>
> sorry, typos.
> generic -> generate.

Please explain how this will solve the syntax issue Ben commented on?

Another syntax which might be simpler is:
<first cpu-last cpu>:<numcpus selected from group>/<cpus group size> e.g.
0-1023:1/2 <==> 0,2,4,...,1022
1-1023:1/2 <==> 1,3,5,...,1023

So basically no need for modulo only divide the list into groups of cpus and 
for each group choose cpus from group start.
It is basically achieves same and hopefully more  simpler and more eligible for 
such generic code.

Please let me know what you think?
Is it good direction to change the syntax, or that I should turn into different 
approach (like Pan suggested)?

Noam.

Reply via email to