On Fri, 9 Sep 2016 17:37:05 -0500 Rob Herring <[email protected]> wrote:
> TTY_IO_ERROR is a property of the tty port rather than the tty, so move > it to tty_port struct and remove another dependency on tty_struct from > drivers. > > Partially converted with coccinelle: > > @@ > identifier t; > identifier func; > @@ > - func(TTY_IO_ERROR, &t->flags) > + func(TTY_PORT_IO_ERROR, &t->port->iflags) > > @@ > expression port; > identifier func; > @@ > - func(TTY_IO_ERROR, &port.tty->flags) > + func(TTY_PORT_IO_ERROR, &port.iflags) Again this makes sense to move the object to the right structure. I'm not convinced your recipe is a correct and reliable translation because you don't capture the flag being cleared if the tty object is freed and then a new one allocated. That needs further review IMHO Alan
