On Tue, Sep 13, 2016 at 6:04 AM, Phil Reid <[email protected]> wrote: > On 12/09/2016 21:40, Linus Walleij wrote: >> >> On Fri, Sep 9, 2016 at 10:31 AM, Colin King <[email protected]> >> wrote: >> >>> From: Colin Ian King <[email protected]> >>> >>> ret is not initialized so it contains garbage. Ensure garbage >>> is not returned in the case that pdata && pdata->teardown is false >>> by initializing ret to 0. >>> >>> Signed-off-by: Colin Ian King <[email protected]> >> >> >> Patch applied. > > G'day Linus, > > > I believe this does the same as Arnd Bergmanns patch from 26 Aug. > [PATCH 1/5] gpio: pca954x: fix undefined error code from remove > > IMO Colin's is the cleaner solution. > Arnd's could be removed.
OK you're right. I reverted Arnd's patch. Yours, Linus Walleij
