On 09/06/2016 05:36 PM, John Garry wrote: > In function phy_up_v2_hw(), we needlessly recalculate the > phy linkrate for all phys, and the calculation is incorrect > for phy8, so remove this code. > > Signed-off-by: John Garry <[email protected]> > Signed-off-by: Xiang Chen <[email protected]> > --- > drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > index aca2b80..ae44443 100644 > --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c > @@ -1876,9 +1876,6 @@ static int phy_up_v2_hw(int phy_no, struct hisi_hba > *hisi_hba) > frame_rcvd[i] = __swab32(idaf); > } > > - /* Get the linkrates */ > - link_rate = hisi_sas_read32(hisi_hba, PHY_CONN_RATE); > - link_rate = (link_rate >> (phy_no * 4)) & 0xf; > sas_phy->linkrate = link_rate; > hard_phy_linkrate = hisi_sas_phy_read32(hisi_hba, phy_no, > HARD_PHY_LINKRATE); > Reviewed-by: Hannes Reinecke <[email protected]>
Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage [email protected] +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
