On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote:
> Any user I can imagine that needs a buffer at all will want to pass
> a pointer directly. There are no currently callers that use
> buffers, so this change is painless, and it will make it much easier
> to start using features that use buffers (e.g. APST).
> Signed-off-by: Andy Lutomirski <l...@kernel.org>
Looks good mostly good, but a nitpick below:
> + /*
> + * Casting buffer to void* is safe here: __nvme_submit_sync_cmd knows
> + * that we're writing because it decodes the opcode.
> + */
> + ret = __nvme_submit_sync_cmd(dev->admin_q, &c, &cqe,
> + (void *)buffer, buflen, 0, NVME_QID_ANY, 0, 0);
Cant we just drop the const annotation to avoid these casts?