On Fri, Sep 02, 2016 at 04:35:54PM +0200, Paolo Bonzini wrote: > > > On 02/09/2016 16:03, Frederic Weisbecker wrote: > > static inline unsigned int u64_stats_fetch_begin(const struct > > u64_stats_sync *syncp) > > { > > -#if BITS_PER_LONG==32 && defined(CONFIG_SMP) > > - return read_seqcount_begin(&syncp->seq); > > -#else > > -#if BITS_PER_LONG==32 > > +#if BITS_PER_LONG==32 && !defined(CONFIG_SMP) > > preempt_disable(); > > +#else > > This should be #endif, or this side ends without a "return" statement.
Good catch! Thanks Paolo!