On Monday, September 19, 2016 3:28:39 PM CEST Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/tonga_smumgr.c:146:5: warning:
> no previous prototype for 'tonga_program_jump_on_start' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/fiji_smumgr.c:816:5: warning:
> no previous prototype for 'fiji_save_vft_table' [-Wmissing-prototypes]
> warning: no previous prototype for 'polaris10_avfs_event_mgr'
> warning: no previous prototype for 'iceland_program_jump_on_start'
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
> Signed-off-by: Baoyou Xie <baoyou....@linaro.org>
All your drm/amd patches seem fine to me, but again (as with the nouveau
driver patches before), I think it would make more sense to consolidate
them, and do a small number of patches such as
[PATCH 1/3] drm/amdgpu: add missing includes
[PATCH 2/3] drm/amdgpu: remove unused functions
[PATCH 3/3] drm/amdgpu: mark symbol static where possible
This is all one big driver, and I see no value in splitting it up
per file within the driver.